linux-kernel - Re: [PATCH] media: vb2: frame_vector.c: replace WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bacb37eb-16ab-4643-bc67-9ecd9f21f4fc@xs4all.nl>
Date:   Thu, 17 Aug 2023 17:02:31 +0200
From:   Hans Verkuil <hverkuil-cisco@...all.nl>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Media Mailing List <linux-media@...r.kernel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Tomasz Figa <tfiga@...omium.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Jan Kara <jack@...e.cz>, David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH] media: vb2: frame_vector.c: replace WARN_ONCE with a
 comment

On 17/08/2023 16:56, Linus Torvalds wrote:
> On Thu, 17 Aug 2023 at 12:41, Hans Verkuil <hverkuil-cisco@...all.nl> wrote:
>>
>> There are no reports of WARN_ONCE being issued for actual VM_IO cases, so
>> just drop it and instead add a note to the comment before the function.
> 
> Ack. That was meant to catch any (unlikely) strange users, but yeah,
> it can obviously be triggered by "intentional" strange users, ie
> syzbot and friends, so since there seems to be no sign of actual
> real-world use, just removing the WARN_ONCE() is the right thing to
> do.
> 
> I'm assuming I'll get this eventually through the regular media pulls?
> 
>                 Linus

Yes, that's the plan.

Regards,

	Hans