[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <64de41e4e5e7c_29e220294b2@dwillia2-xfh.jf.intel.com.notmuch>
Date: Thu, 17 Aug 2023 08:51:00 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Konstantin Meskhidze <konstantin.meskhidze@...wei.com>,
<dan.j.williams@...el.com>
CC: <vishal.l.verma@...el.com>, <dave.jiang@...el.com>,
<ira.weiny@...el.com>, <nvdimm@...ts.linux.dev>,
<linux-kernel@...r.kernel.org>, <yusongping@...wei.com>,
<artem.kuzin@...wei.com>, <kjain@...ux.ibm.com>
Subject: RE: [PATCH] drivers: nvdimm: fix dereference after free
[ add Kajol ]
Konstantin Meskhidze wrote:
> 'nd_pmu->pmu.attr_groups' is dereferenced in function
> 'nvdimm_pmu_free_hotplug_memory' call after it has been freed. Because in
> function 'nvdimm_pmu_free_hotplug_memory' memory pointed by the fields of
> 'nd_pmu->pmu.attr_groups' is deallocated it is necessary to call 'kfree'
> after 'nvdimm_pmu_free_hotplug_memory'.
Another one that would be fixed by static attribute groups.
I do think we should move forward with these fixes as is for ease of backport,
but long term this dynamically allocated attribute groups approach needs to be
jettisoned. ...unless I am missing a concrete reason it needs to remain dynamic?
Powered by blists - more mailing lists