linux-kernel - Re: [PATCH] drivers: nvdimm: fix dereference after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0744195e-181f-2e96-b18b-98c39985cfcc@intel.com>
Date:   Thu, 17 Aug 2023 09:04:45 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Konstantin Meskhidze <konstantin.meskhidze@...wei.com>,
        <dan.j.williams@...el.com>
CC:     <vishal.l.verma@...el.com>, <ira.weiny@...el.com>,
        <nvdimm@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
        <yusongping@...wei.com>, <artem.kuzin@...wei.com>
Subject: Re: [PATCH] drivers: nvdimm: fix dereference after free



On 8/17/23 08:45, Dave Jiang wrote:
> 
> 
> On 8/17/23 04:41, Konstantin Meskhidze wrote:
>> 'nd_pmu->pmu.attr_groups' is dereferenced in function
>> 'nvdimm_pmu_free_hotplug_memory' call after it has been freed. Because in
>> function 'nvdimm_pmu_free_hotplug_memory' memory pointed by the fields of
>> 'nd_pmu->pmu.attr_groups' is deallocated it is necessary to call 'kfree'
>> after 'nvdimm_pmu_free_hotplug_memory'.
>>
>> Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@...wei-partners.com>
>> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@...wei.com>
> 
> LGTM
> 
> Does this need a Fixes tag?

Applied. Modified subject to "nvdimm: Fix dereference after free in 
register_nvdimm_pmu()"

Also added Fixes tag:
Fixes: 0fab1ba6ad6b ("drivers/nvdimm: Add perf interface to expose 
nvdimm performance stats")


> 
>> ---
>>   drivers/nvdimm/nd_perf.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/nvdimm/nd_perf.c b/drivers/nvdimm/nd_perf.c
>> index 14881c4e0..2b6dc80d8 100644
>> --- a/drivers/nvdimm/nd_perf.c
>> +++ b/drivers/nvdimm/nd_perf.c
>> @@ -307,10 +307,10 @@ int register_nvdimm_pmu(struct nvdimm_pmu 
>> *nd_pmu, struct platform_device *pdev)
>>       }
>>       rc = perf_pmu_register(&nd_pmu->pmu, nd_pmu->pmu.name, -1);
>>       if (rc) {
>> -        kfree(nd_pmu->pmu.attr_groups);
>>           nvdimm_pmu_free_hotplug_memory(nd_pmu);
>> +        kfree(nd_pmu->pmu.attr_groups);
>>           return rc;
>>       }
>>       pr_info("%s NVDIMM performance monitor support registered\n",
>