linux-kernel - Re: [PATCH] mm,ima,kexec,of: use memblock_free_late from ima_free_kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <169237726559.146063.4251885159536892099.robh@kernel.org>
Date:   Fri, 18 Aug 2023 11:47:57 -0500
From:   Rob Herring <robh@...nel.org>
To:     Rik van Riel <riel@...riel.com>
Cc:     devicetree@...r.kernel.org, kernel-team@...a.com,
        Frank Rowand <frowand.list@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm,ima,kexec,of: use memblock_free_late from
 ima_free_kexec_buffer


On Thu, 17 Aug 2023 13:57:59 -0400, Rik van Riel wrote:
> The code calling ima_free_kexec_buffer runs long after the memblock
> allocator has already been torn down, potentially resulting in a use
> after free in memblock_isolate_range.
> 
> With KASAN or KFENCE, this use after free will result in a BUG
> from the idle task, and a subsequent kernel panic.
> 
> Switch ima_free_kexec_buffer over to memblock_free_late to avoid
> that issue.
> 
> Fixes: fee3ff99bc67 ("powerpc: Move arch independent ima kexec functions to
> drivers/of/kexec.c")
> Cc: stable@...nel.org
> Signed-off-by: Rik van Riel <riel@...riel.com>
> Suggested-by: Mike Rappoport <rppt@...nel.org>
> ---
>  drivers/of/kexec.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Applied, thanks!