linux-kernel - Re: [PATCH 6/6] soc/tegra: fuse: Add support for Tegra241

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230821114033.4446-1-kkartik@nvidia.com>
Date:   Mon, 21 Aug 2023 17:10:33 +0530
From:   Kartik <kkartik@...dia.com>
To:     <andriy.shevchenko@...ux.intel.com>
CC:     <arnd@...db.de>, <digetx@...il.com>, <frank.li@...o.com>,
        <jonathanh@...dia.com>, <kkartik@...dia.com>,
        <linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <pdeschrijver@...dia.com>, <petlozup@...dia.com>,
        <pshete@...dia.com>, <robh@...nel.org>, <stefank@...dia.com>,
        <sumitg@...dia.com>, <thierry.reding@...il.com>, <windhl@....com>
Subject: Re: [PATCH 6/6] soc/tegra: fuse: Add support for Tegra241

On Fri, 2023-08-18 at 18:10 +0300, Andy Shevchenko wrote:
>On Fri, Aug 18, 2023 at 03:00:28PM +0530, Kartik wrote:
>> Add support for Tegra241 which use ACPI boot.
>
>...
>
>>  	case TEGRA234:
>>  		fuse->soc = &tegra234_fuse_soc;
>>  		break;
>> +#endif
>> +#if defined(CONFIG_ARCH_TEGRA_241_SOC)
>> +	case TEGRA241:
>> +		fuse->soc = &tegra241_fuse_soc;
>> +		break;
>>  #endif
>
>Have you tried --patience when formatting patches?
>Does it help them to look better?
>

No, I did not use --patience flag while formatting the patches.
Shall I post the next patch set using it?

>...
>
>> +const struct tegra_fuse_soc tegra241_fuse_soc = {
>> +	.init = tegra30_fuse_init,
>> +	.info = &tegra241_fuse_info,
>
>> +	.lookups = NULL,
>> +	.num_lookups = 0,
>> +	.cells = NULL,
>> +	.num_cells = 0,
>
>Isn't it the default?
>
>> +	.keepouts = tegra241_fuse_keepouts,
>> +	.num_keepouts = ARRAY_SIZE(tegra241_fuse_keepouts),
>> +	.soc_attr_group = &tegra194_soc_attr_group,
>
>> +	.clk_suspend_on = false,
>
>Ditto.
>

Yes, I will trim this list in the next patch.

>> +};

Regards,
Kartik