linux-kernel - Re: [PATCH 1/6] soc/tegra: fuse: Add tegra_acpi_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZONZaZ1QaWKBCMYj@smile.fi.intel.com>
Date:   Mon, 21 Aug 2023 15:32:41 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Kartik <kkartik@...dia.com>
Cc:     arnd@...db.de, digetx@...il.com, frank.li@...o.com,
        jonathanh@...dia.com, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, pdeschrijver@...dia.com,
        petlozup@...dia.com, pshete@...dia.com, robh@...nel.org,
        stefank@...dia.com, sumitg@...dia.com, thierry.reding@...il.com,
        windhl@....com
Subject: Re: [PATCH 1/6] soc/tegra: fuse: Add tegra_acpi_init_apbmisc()

On Mon, Aug 21, 2023 at 05:02:20PM +0530, Kartik wrote:
> On Fri, 2023-08-18 at 16:21 +0300, Andy Shevchenko wrote:

...

> >>  void tegra_init_revision(void);
> >>  void tegra_init_apbmisc(void);
> >> +void tegra_acpi_init_apbmisc(void);
> >
> >Why do you  need a separate function?
> 
> Function tegra_init_apbmisc() is called from tegra_init_fuse() which
> is invoked at early init and it also has `__init` keyword. If we use
> the same function for both ACPI/DT, then we will get init section
> mismatches when the Tegra Fuse driver probes using ACPI.
> 
> We can use the same function by dropping the `init` keyword. But
> the way we are getting the resources for device-tree and on ACPI is
> slightly different. Hence, I kept a separate function for ACPI
> and move the common bits to a function shared between
> tegra_init_apbmisc() and tegra_acpi_init_apbmisc().

So, you mean that behaviour is different for ACPI and DT cases.
Then obvious question why DT case can't be delayed to not so early
stage to be run? This requires some explanations, more than given
in the commit message and here.

-- 
With Best Regards,
Andy Shevchenko