linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: Enable tsens and thermal for sa8775p SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac153c9b-f698-47f4-9d52-b3ea5c9ba213@kernel.org>
Date:   Mon, 21 Aug 2023 13:55:27 +0200
From:   Konrad Dybcio <konradybcio@...nel.org>
To:     Priyansh Jain <quic_priyjain@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Amit Kucheria <amitk@...nel.org>,
        Thara Gopinath <thara.gopinath@...il.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_manafm@...cinc.com
Subject: Re: [PATCH 2/2] arm64: dts: qcom: Enable tsens and thermal for
 sa8775p SoC

On 21.08.2023 13:29, Priyansh Jain wrote:
> Add tsens and thermal devicetree node for sa8775p SoC.
> 
> Signed-off-by: Priyansh Jain <quic_priyjain@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 1096 +++++++++++++++++++++++++
>  1 file changed, 1096 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index b130136acffe..b9c622b3bf7e 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -2306,6 +2306,1102 @@
>  
>  			#freq-domain-cells = <1>;
>  		};
> +
> +		tsens0: thermal-sensor@...2000 {
> +			compatible = "qcom,sa8775p-tsens", "qcom,tsens-v2";
> +			reg = <0x0C263000 0x1ff>,  /* TM */
> +				<0x0C222000 0x1ff>; /* SROT */
1. Test your patches. This will obviously not work due to the
   #address/size-cells values of /soc@0.

2. Use lowercase hex.

3. Align subsequent entries for a property with the previous line

4. Are you sure SROT is 0x1ff-long?

5. The usefulness of these comments is questionable, many DTs have
   them because of copypasta but I think it's time to stop that.

6. No pdc wake-capable interrupts?

> +			#qcom,sensors = <12>;
> +			interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "uplow","critical";
Missing space after the comma

Please move interrupt properties right after 'reg'.

Konrad