linux-kernel - Re: [PATCH] maple_tree: shrink struct maple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230822140946.kbmv43l4uhwwqwln@revolver>
Date:   Tue, 22 Aug 2023 10:09:46 -0400
From:   "Liam R. Howlett" <Liam.Howlett@...cle.com>
To:     Mateusz Guzik <mjguzik@...il.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, maple-tree@...ts.infradead.org
Subject: Re: [PATCH] maple_tree: shrink struct maple_tree from 24 to 16 bytes
 on LP64

* Mateusz Guzik <mjguzik@...il.com> [230821 18:52]:
> by plugging a padding hole.
> 
> [sounds like an obvious thing to do, am I missing something?]

Thanks for the patch.  There is no reason for the current ordering.

I've tested both 32 and 64 bit userspace testing to double check
everything still works.

> 
> Signed-off-by: Mateusz Guzik <mjguzik@...il.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>

> ---
>  include/linux/maple_tree.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h
> index 295548cca8b3..5bdd3ce34cb9 100644
> --- a/include/linux/maple_tree.h
> +++ b/include/linux/maple_tree.h
> @@ -212,8 +212,8 @@ struct maple_tree {
>  		spinlock_t	ma_lock;
>  		lockdep_map_p	ma_external_lock;
>  	};
> -	void __rcu      *ma_root;
>  	unsigned int	ma_flags;
> +	void __rcu      *ma_root;
>  };
>  
>  /**
> -- 
> 2.39.2
> 
>