linux-kernel - Re: [PATCH v1] PCI: qcom: Add sysfs entry to change link speed dynamically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202308222302.9EPeENqh-lkp@intel.com>
Date:   Tue, 22 Aug 2023 23:54:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Krishna chaitanya chundru <quic_krichai@...cinc.com>,
        manivannan.sadhasivam@...aro.org
Cc:     oe-kbuild-all@...ts.linux.dev, helgaas@...nel.org,
        linux-pci@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_vbadigan@...cinc.com,
        quic_nitegupt@...cinc.com, quic_skananth@...cinc.com,
        quic_ramkri@...cinc.com, quic_parass@...cinc.com,
        krzysztof.kozlowski@...aro.org,
        Krishna chaitanya chundru <quic_krichai@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v1] PCI: qcom: Add sysfs entry to change link speed
 dynamically

Hi Krishna,

kernel test robot noticed the following build errors:

[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus linus/master v6.5-rc7 next-20230822]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Krishna-chaitanya-chundru/PCI-qcom-Add-sysfs-entry-to-change-link-speed-dynamically/20230817-103734
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/1692239684-12697-1-git-send-email-quic_krichai%40quicinc.com
patch subject: [PATCH v1] PCI: qcom: Add sysfs entry to change link speed dynamically
config: loongarch-randconfig-r005-20230822 (https://download.01.org/0day-ci/archive/20230822/202308222302.9EPeENqh-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230822/202308222302.9EPeENqh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308222302.9EPeENqh-lkp@intel.com/

All errors (new ones prefixed by >>):

   loongarch64-linux-ld: drivers/pci/controller/dwc/pcie-qcom.o: in function `qcom_pcie_speed_change_store':
>> drivers/pci/controller/dwc/pcie-qcom.c:375:(.text+0xc14): undefined reference to `qcom_pcie_opp_update'


vim +375 drivers/pci/controller/dwc/pcie-qcom.c

   303	
   304	static ssize_t qcom_pcie_speed_change_store(struct device *dev,
   305				       struct device_attribute *attr,
   306				       const char *buf,
   307				       size_t count)
   308	{
   309		unsigned int current_speed, target_speed, max_speed;
   310		struct qcom_pcie *pcie = dev_get_drvdata(dev);
   311		struct pci_bus *child, *root_bus = NULL;
   312		struct dw_pcie_rp *pp = &pcie->pci->pp;
   313		struct dw_pcie *pci = pcie->pci;
   314		struct pci_dev *pdev;
   315		u16 offset;
   316		u32 val;
   317		int ret;
   318	
   319		list_for_each_entry(child, &pp->bridge->bus->children, node) {
   320			if (child->parent == pp->bridge->bus) {
   321				root_bus = child;
   322				break;
   323			}
   324		}
   325	
   326		pdev = root_bus->self;
   327	
   328		offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);
   329	
   330		val = readl(pci->dbi_base + offset + PCI_EXP_LNKCAP);
   331		max_speed = FIELD_GET(PCI_EXP_LNKCAP_SLS, val);
   332	
   333		val = readw(pci->dbi_base + offset + PCI_EXP_LNKSTA);
   334		current_speed = FIELD_GET(PCI_EXP_LNKSTA_CLS, val);
   335	
   336		ret = kstrtouint(buf, 10, &target_speed);
   337		if (ret)
   338			return ret;
   339	
   340		if (target_speed > max_speed)
   341			return -EINVAL;
   342	
   343		if (current_speed == target_speed)
   344			return count;
   345	
   346		pci_walk_bus(pp->bridge->bus, qcom_pcie_disable_l0s, pcie);
   347	
   348		/* Disable L1 */
   349		val = dw_pcie_readl_dbi(pci, offset + PCI_EXP_LNKCTL);
   350		val &= ~(PCI_EXP_LNKCTL_ASPM_L1);
   351		dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCTL, val);
   352	
   353		/* Set target GEN speed */
   354		val = dw_pcie_readl_dbi(pci, offset + PCI_EXP_LNKCTL2);
   355		val &= ~PCI_EXP_LNKCTL2_TLS;
   356		dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCTL2, val | target_speed);
   357	
   358		ret = pcie_retrain_link(pdev, true);
   359		if (ret)
   360			dev_err(dev, "Link retrain failed %d\n", ret);
   361	
   362		/* Enable L1 */
   363		val = dw_pcie_readl_dbi(pci, offset + PCI_EXP_LNKCTL);
   364		val |= (PCI_EXP_LNKCTL_ASPM_L1);
   365		dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCTL, val);
   366	
   367		pcie->l0s_supported = true;
   368		pci_walk_bus(pp->bridge->bus, qcom_pcie_check_l0s_support, pcie);
   369	
   370		if (pcie->l0s_supported)
   371			pci_walk_bus(pp->bridge->bus, qcom_pcie_enable_l0s, pcie);
   372	
   373		qcom_pcie_icc_update(pcie);
   374	
 > 375		qcom_pcie_opp_update(pcie);
   376	
   377		return count;
   378	}
   379	static DEVICE_ATTR_WO(qcom_pcie_speed_change);
   380	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki