linux-kernel - Re: [PATCH] Fix encoding of ethernet frame length for big endian platforms in QCA7000/7005 protocol header.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef21625d-5df7-4421-ab5b-3d49b83c553e@lunn.ch>
Date:   Tue, 22 Aug 2023 18:08:48 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     kornel.swierzy@...evity.com
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix encoding of ethernet frame length for big endian
 platforms in QCA7000/7005 protocol header.

On Tue, Aug 22, 2023 at 08:59:56AM +0200, kornel.swierzy@...evity.com wrote:
> From: Kornel Swierzy <kornel.swierzy@...evity.com>
> 
> QCA7000 protocol requires that ethernet frame length is encoded
> as u16 little endian value. Current implementation does not work
> on big endian architectures.
> 
> Signed-off-by: Kornel Swierzy <kornel.swierzy@...evity.com>

Hi Kornel

Please take a look at

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq

and

https://docs.kernel.org/process/submitting-patches.html

This appears to be a bugfix, so it should have a Fixes: tag. It then
should be based on the net tree, and this should be indicated in the
Subject: line.

That change itself looks fine, you just have some process issues to
correct.

	Andrew