linux-kernel - [PATCH] Fix encoding of ethernet frame length for big endian platforms in QCA7000/7005 protocol header.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 26 Aug 2023 06:43:08 +0200
From:   kornel.swierzy@...evity.com
To:     andrew@...n.ch
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Kornel Swierzy <kornel.swierzy@...evity.com>
Subject: [PATCH] Fix encoding of ethernet frame length for big endian platforms in QCA7000/7005 protocol header.

From: Kornel Swierzy <kornel.swierzy@...evity.com>

On 8/22/23 18:08, Andrew Lunn wrote:

> On Tue, Aug 22, 2023 at 08:59:56AM +0200, kornel.swierzy@...evity.com wrote:
>> From: Kornel Swierzy <kornel.swierzy@...evity.com>
>>
>> QCA7000 protocol requires that ethernet frame length is encoded
>> as u16 little endian value. Current implementation does not work
>> on big endian architectures.
>>
>> Signed-off-by: Kornel Swierzy <kornel.swierzy@...evity.com>
> Hi Kornel
>
> Please take a look at
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
>
> and
>
> https://docs.kernel.org/process/submitting-patches.html
>
> This appears to be a bugfix, so it should have a Fixes: tag. It then
> should be based on the net tree, and this should be indicated in the
> Subject: line.
>
> That change itself looks fine, you just have some process issues to
> correct.
>
> 	Andrew

Hi Andrew,

thanks for the answer and help in submitting my first patch.

I have one question regarding your comment on which I couldn't find any 
answer in the internet: should I post the patch with corrected subject 
and added "fixes" line as an reply to this conversation or it is better 
to submit it as a new patch?


Best regards,

Kornel