linux-kernel - Re: [PATCH 1/2] ACPI: NFIT: Fix incorrect calculation of idt size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ffd6004f-f30c-8bc3-096b-e3bce93ee864@huawei.com>
Date:   Sat, 26 Aug 2023 12:37:27 +0800
From:   Yu Liao <liaoyu15@...wei.com>
To:     Dave Jiang <dave.jiang@...el.com>, <dan.j.williams@...el.com>,
        <vishal.l.verma@...el.com>, <ira.weiny@...el.com>,
        <rafael@...nel.org>
CC:     <liwei391@...wei.com>, <lenb@...nel.org>, <robert.moore@...el.com>,
        <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ACPI: NFIT: Fix incorrect calculation of idt size

On 2023/8/25 23:09, Dave Jiang wrote:
> 
> 
> On 8/24/23 20:59, Yu Liao wrote:
>> Hi,
>>
>> A kindly ping, any comment on this?
> 
> You can add my review tag to both of your patches in the series. Please cc
> nvdimm@...ts.linux.dev next time as well for nfit. Thanks!

Thank you for the review. I'll make the suggested changes and send you
the V2.

Best regards,
Yu
> 
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> 
>>
>> Best regards,
>> Yu
>>
>>
>> On 2023/8/17 17:11, Yu Liao wrote:
>>> acpi_nfit_interleave's field 'line_offset' is switched to flexible array [1],
>>> but sizeof_idt() still calculates the size in the form of 1-element array.
>>>
>>> Therefore, fix incorrect calculation in sizeof_idt().
>>>
>>> [1] https://lore.kernel.org/lkml/2652195.BddDVKsqQX@kreacher/
>>>
>>> Fixes: 2a5ab99847bd ("ACPICA: struct acpi_nfit_interleave: Replace
>>> 1-element array with flexible array")
>>> Cc: stable@...r.kernel.org # v6.4+
>>> Signed-off-by: Yu Liao <liaoyu15@...wei.com>
>>> ---
>>>   drivers/acpi/nfit/core.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
>>> index 07204d482968..305f590c54a8 100644
>>> --- a/drivers/acpi/nfit/core.c
>>> +++ b/drivers/acpi/nfit/core.c
>>> @@ -855,7 +855,7 @@ static size_t sizeof_idt(struct acpi_nfit_interleave *idt)
>>>   {
>>>       if (idt->header.length < sizeof(*idt))
>>>           return 0;
>>> -    return sizeof(*idt) + sizeof(u32) * (idt->line_count - 1);
>>> +    return sizeof(*idt) + sizeof(u32) * idt->line_count;
>>>   }
>>>     static bool add_idt(struct acpi_nfit_desc *acpi_desc,
>>