[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230822040745.260086-1-sultan@kerneltoast.com>
Date: Mon, 21 Aug 2023 21:07:41 -0700
From: Sultan Alsawaf <sultan@...neltoast.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Sultan Alsawaf <sultan@...neltoast.com>,
Gregory Greenman <gregory.greenman@...el.com>,
Kalle Valo <kvalo@...nel.org>,
Johannes Berg <johannes.berg@...el.com>,
Miri Korenblit <miriam.rachel.korenblit@...el.com>,
linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] wifi: iwlwifi: mvm: fix power save for MLD
From: Sultan Alsawaf <sultan@...neltoast.com>
The conversion from bss_info_changed() to vif_cfg/link_info_changed()
removed a call to iwl_mvm_bss_info_changed_station_common() from what
became the vif_cfg_changed() path. As a result, BSS_CHANGED_PS and other
power save changes sent via ieee80211_vif_cfg_change_notify() are ignored
for MLD, which breaks power save entirely. This has a noticeable impact on
power consumption, causing idle package power to hover at 10 W on my
i9-13980HX laptop with an AX210 while connected to WiFi.
Add the missing iwl_mvm_bss_info_changed_station_common() call to the
vif_cfg_changed() path to fix power save for MLD. This brings idle package
power down to 1 W on my laptop, a 9 W improvement.
Fixes: 22c588343529 ("wifi: iwlwifi: mvm: replace bss_info_changed() with vif_cfg/link_info_changed()")
Signed-off-by: Sultan Alsawaf <sultan@...neltoast.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c
index 8b6c641772ee..6abc05976870 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c
@@ -731,6 +731,8 @@ static void iwl_mvm_mld_vif_cfg_changed_station(struct iwl_mvm *mvm,
mvmvif->associated = vif->cfg.assoc;
+ iwl_mvm_bss_info_changed_station_common(mvm, vif, &vif->bss_conf,
+ changes);
if (!(changes & BSS_CHANGED_ASSOC))
return;
--
2.41.0
Powered by blists - more mailing lists