linux-kernel - Re: [PATCH AUTOSEL 4.14 4/9] vxlan: generalize vxlan_parse_gpe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOSR1KDjz6Qq2eUa@duo.ucw.cz>
Date:   Tue, 22 Aug 2023 12:45:40 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jiri Benc <jbenc@...hat.com>,
        "David S . Miller" <davem@...emloft.net>, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 4/9] vxlan: generalize vxlan_parse_gpe_hdr
 and remove unused args

Hi!

> From: Jiri Benc <jbenc@...hat.com>
> 
> [ Upstream commit 17a0a64448b568442a101de09575f81ffdc45d15 ]
> 
> The vxlan_parse_gpe_hdr function extracts the next protocol value from
> the GPE header and marks GPE bits as parsed.
> 
> In order to be used in the next patch, split the function into protocol
> extraction and bit marking. The bit marking is meaningful only in
> vxlan_rcv; move it directly there.
> 
> Rename the function to vxlan_parse_gpe_proto to reflect what it now
> does. Remove unused arguments skb and vxflags. Move the function earlier
> in the file to allow it to be called from more places in the next
> patch.

This seems to be a cleanup/preparation for a patch we don't have
queued for 4.14. Please drop.

Best regards,
							Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)