linux-kernel - Re: [PATCH AUTOSEL 4.14 7/9] fs/nls: make load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZOSR/YOFU66otZmO@duo.ucw.cz>
Date:   Tue, 22 Aug 2023 12:46:21 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Winston Wen <wentao@...ontech.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Paulo Alcantara <pc@...guebit.com>,
        Christian Brauner <brauner@...nel.org>,
        Steve French <stfrench@...rosoft.com>
Subject: Re: [PATCH AUTOSEL 4.14 7/9] fs/nls: make load_nls() take a const
 parameter

On Sun 2023-08-13 12:14:25, Sasha Levin wrote:
> From: Winston Wen <wentao@...ontech.com>
> 
> [ Upstream commit c1ed39ec116272935528ca9b348b8ee79b0791da ]
> 
> load_nls() take a char * parameter, use it to find nls module in list or
> construct the module name to load it.
> 
> This change make load_nls() take a const parameter, so we don't need do
> some cast like this:
> 
>         ses->local_nls = load_nls((char *)ctx->local_nls->charset);

Nice cleanup, but should not be in stable.

Best regards,
								Pavel
							
> Suggested-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Winston Wen <wentao@...ontech.com>
> Reviewed-by: Paulo Alcantara <pc@...guebit.com>
> Reviewed-by: Christian Brauner <brauner@...nel.org>
> Signed-off-by: Steve French <stfrench@...rosoft.com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  fs/nls/nls_base.c   | 4 ++--
>  include/linux/nls.h | 2 +-

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)