linux-kernel - Re: [PATCH 1/2] dt-bindings: crypto: qcom,prng: document SM8550

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b73106c5-74e4-479d-8733-b99454768c15@quicinc.com>
Date:   Tue, 22 Aug 2023 20:24:43 +0530
From:   Om Prakash Singh <quic_omprsing@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Vinod Koul <vkoul@...nel.org>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: crypto: qcom,prng: document SM8550

PRNG Block on most of newer target from Qualcomm have some configuration 
where clock is configured by security firmware.

Adding separate compatible string for each platform is overhead.

We need to introduce common compatible string that can be used for all 
platforms with same configuration.

I would suggest to use "qcom,rng-ee" for newer platform, dropping "p" 
also signifies it is not a Pseudo Random Number Generator.

On 8/22/2023 7:58 PM, Konrad Dybcio wrote:
> On 22.08.2023 16:11, Neil Armstrong wrote:
>> Document SM8550 compatible for Pseudo Random Generator,
>> like SM8450 doesn't require clocks setup done by the secure
>> firmware.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>> ---
> + CC Om
> 
> As mentioned in [1], perhaps we should rethink the compatible as
> it may be a TRNG and not a PRNG?
> 
> Konrad
> 
> [1] https://lore.kernel.org/linux-arm-msm/d93902ee-c305-42cb-9d0d-1f0971ab3a70@quicinc.com/