linux-kernel - Re: [PATCH 1/2] RDMA/rxe: add missing newline to rxe_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=hENcGfS0++mTTX4z-YT3SAx=5OYyqSf89=AkOCD9+SrUtag@mail.gmail.com>
Date:   Wed, 23 Aug 2023 14:35:53 +0800
From:   Zhu Yanjun <zyjzyj2000@...il.com>
To:     "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>, pmladek@...e.com,
        senozhatsky@...omium.org, Steven Rostedt <rostedt@...dmis.org>,
        john.ogness@...utronix.de
Cc:     Zhu Yanjun <yanjun.zhu@...ux.dev>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "jgg@...pe.ca" <jgg@...pe.ca>, "leon@...nel.org" <leon@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "rpearsonhpe@...il.com" <rpearsonhpe@...il.com>
Subject: Re: [PATCH 1/2] RDMA/rxe: add missing newline to rxe_set_mtu message

On Wed, Aug 23, 2023 at 2:25 PM Zhijian Li (Fujitsu)
<lizhijian@...itsu.com> wrote:
>
>
>
> On 23/08/2023 14:12, Zhu Yanjun wrote:
> > 在 2023/8/23 10:13, Li Zhijian 写道:
> >> A newline help flushing message out.
> >
> > rxe_info_dev will finally call printk to output information.
> >
> > In this link https://github.com/torvalds/linux/blob/master/Documentation/core-api/printk-basics.rst,
> > "
> > All printk() messages are printed to the kernel log buffer, which is a ring buffer exported to userspace through /dev/kmsg. The usual way to read it is using dmesg.
> > "
> > Do you mean that a new line will help the kernel log buffer flush message out?
>
> Yeah, the message will be buffered until it is full or it meets a newline.

Add PRINTK reviewers:

Petr Mladek <pmladek@...e.com>
Sergey Senozhatsky <senozhatsky@...omium.org>
Steven Rostedt <rostedt@...dmis.org>
 John Ogness <john.ogness@...utronix.de>

This is about printk. They can decide this commit.

Zhu Yanjun

>
>
>
> >
> > Zhu Yanjun
> >>
> >> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> >> ---
> >>   drivers/infiniband/sw/rxe/rxe.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
> >> index 54c723a6edda..cb2c0d54aae1 100644
> >> --- a/drivers/infiniband/sw/rxe/rxe.c
> >> +++ b/drivers/infiniband/sw/rxe/rxe.c
> >> @@ -161,7 +161,7 @@ void rxe_set_mtu(struct rxe_dev *rxe, unsigned int ndev_mtu)
> >>       port->attr.active_mtu = mtu;
> >>       port->mtu_cap = ib_mtu_enum_to_int(mtu);
> >> -    rxe_info_dev(rxe, "Set mtu to %d", port->mtu_cap);
> >> +    rxe_info_dev(rxe, "Set mtu to %d\n", port->mtu_cap);
> >>   }
> >>   /* called by ifc layer to create new rxe device.
> >