linux-kernel - Re: [PATCH net-next] net: dsa: use capital "OR" for multiple licenses in SPDX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <601f8735-39ea-7579-0047-3d3358851339@linaro.org>
Date:   Wed, 23 Aug 2023 11:47:19 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Kurt Kanzenbach <kurt@...utronix.de>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH net-next] net: dsa: use capital "OR" for multiple licenses
 in SPDX

On 23/08/2023 11:32, Kurt Kanzenbach wrote:
> On Wed Aug 23 2023, Krzysztof Kozlowski wrote:
>> Documentation/process/license-rules.rst and checkpatch expect the SPDX
>> identifier syntax for multiple licenses to use capital "OR".  Correct it
>> to keep consistent format and avoid copy-paste issues.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>
> 
> Side note: The SPDX spec in section D.2 says: "License expression
> operators (AND, OR and WITH) should be matched in a case-sensitive
> manner.". Should is not must. So I assume checkpatch and spdxcheck
> should handle both cases. Especially because:
> 
> |linux (git)-[master] % git grep 'SPDX' | grep ' or ' | wc -l
> |370
> 

But "should" denotes preferred rule:

git grep "SPDX-Li" | grep " OR " | wc -l	
7661

Best regards,
Krzysztof