linux-kernel - Re: [PATCH net-next] net: dsa: use capital "OR" for multiple licenses in SPDX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87edju9ggi.fsf@kurt>
Date:   Wed, 23 Aug 2023 12:54:37 +0200
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH net-next] net: dsa: use capital "OR" for multiple
 licenses in SPDX

On Wed Aug 23 2023, Krzysztof Kozlowski wrote:
> On 23/08/2023 11:32, Kurt Kanzenbach wrote:
>> On Wed Aug 23 2023, Krzysztof Kozlowski wrote:
>>> Documentation/process/license-rules.rst and checkpatch expect the SPDX
>>> identifier syntax for multiple licenses to use capital "OR".  Correct it
>>> to keep consistent format and avoid copy-paste issues.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> 
>> Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>
>> 
>> Side note: The SPDX spec in section D.2 says: "License expression
>> operators (AND, OR and WITH) should be matched in a case-sensitive
>> manner.". Should is not must. So I assume checkpatch and spdxcheck
>> should handle both cases. Especially because:
>> 
>> |linux (git)-[master] % git grep 'SPDX' | grep ' or ' | wc -l
>> |370
>> 
>
> But "should" denotes preferred rule:

Yes, of course :).

You mentioned checkpatch. But checkpatch doesn't warn about it. Or does
it? 

|linux (git)-[master] % ./scripts/checkpatch.pl -- drivers/net/dsa/hirschmann/hellcreek.h
|total: 0 errors, 0 warnings, 0 checks, 321 lines checked
|
|drivers/net/dsa/hirschmann/hellcreek.h has no obvious style problems and
|is ready for submission.

What about something like this?

|linux (git)-[master*] % ./scripts/checkpatch.pl -- drivers/net/dsa/hirschmann/hellcreek.h
|WARNING: License expression operators (AND, OR, WITH) should be upper case
|#1: FILE: drivers/net/dsa/hirschmann/hellcreek.h:1:
|+/* SPDX-License-Identifier: (GPL-2.0 or MIT) */
|
|total: 0 errors, 1 warnings, 0 checks, 321 lines checked
|
|NOTE: For some of the reported defects, checkpatch may be able to
|      mechanically convert to the typical style using --fix or --fix-inplace.
|
|drivers/net/dsa/hirschmann/hellcreek.h has style problems, please review.
|
|NOTE: If any of the errors are false positives, please report
|      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)