[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230824185054.GA3659959@shaak>
Date: Thu, 24 Aug 2023 14:50:54 -0400
From: Liam Beguin <liambeguin@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: iio: adc: add lltc,ltc2309 bindings
On Thu, Aug 24, 2023 at 07:56:29PM +0200, Krzysztof Kozlowski wrote:
> On 24/08/2023 18:55, Liam Beguin wrote:
> > Add devicetree bindings for the Linear Technology LTC2309 ADC driver.
> >
> > Signed-off-by: Liam Beguin <liambeguin@...il.com>
>
> Thank you for your patch. There is something to discuss/improve.
>
> > +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2309.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: GPL-2.0
>
> Wrong license. Run checkpatch before sending patches.
>
Sorry about that, I ran it through checkpatch but it didn't flag
anything.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/adc/lltc,ltc2309.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Linear Technology / Analog Devices LTC2309 ADC
> > +
> > +maintainers:
> > + - Liam Beguin <liambeguin@...il.com>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - lltc,ltc2309
> > +
> > + refcomp-supply:
> > + description: Power supply for the reference voltage
>
> refcomp is not a supply. It is called "Reference Buffer Output.". You
That makes sense, I was going for the PIN name from the datasheet.
> probably wanted vref-supply, which suggests you should just add it to
> ltc2497 bindings. I don't see any differences.
>
I hadn't thought of reusing an existing bindings file for a different
driver. I'll update ltc2497.yaml instead since it avoids duplicating the
whole file.
> > +
> > + reg:
> > + enum:
> > + - 0x08
> > + - 0x09
> > + - 0x0a
> > + - 0x0b
> > + - 0x18
> > + - 0x19
> > + - 0x1a
> > + - 0x1b
> > + - 0x28
> > +
> > + "#io-channel-cells":
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + adc@28 {
> > + #io-channel-cells = <1>;
> > + compatible = "lltc,ltc2309";
> > + reg = <0x28>;
>
> If the example stays, then order is compatible first, then reg, then the
> rest. Also add the supply to make example complete.
Thanks for pointing out the proper order.
> But I think this should be squashed with other binding so no need for
> the example.
>
> Best regards,
> Krzysztof
>
Thanks for your time!
Liam
Powered by blists - more mailing lists