linux-kernel - Re: [PATCHv5 3/4] dt-bindings: wiegand: add GPIO bitbanged Wiegand controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Aug 2023 07:32:06 -0500
From:   Rob Herring <robh@...nel.org>
To:     Martin Zaťovič <m.zatovic1@...il.com>
Cc:     benjamin.tissoires@...hat.com, arnd@...db.de, axboe@...nel.dk,
        andriy.shevchenko@...el.com, nipun.gupta@....com,
        conor+dt@...nel.org, linux-kernel@...r.kernel.org,
        quic_jhugo@...cinc.com, jacek.lawrynowicz@...ux.intel.com,
        gregkh@...uxfoundation.org, geert+renesas@...der.be,
        mathieu.poirier@...aro.org, masahiroy@...nel.org,
        linus.walleij@...aro.org, tzimmermann@...e.de,
        devicetree@...r.kernel.org, ogabbay@...nel.org,
        krzysztof.kozlowski+dt@...aro.org,
        damien.lemoal@...nsource.wdc.com, linux@...y.sk,
        yangyicong@...ilicon.com, robh+dt@...nel.org
Subject: Re: [PATCHv5 3/4] dt-bindings: wiegand: add GPIO bitbanged Wiegand
 controller


On Thu, 24 Aug 2023 13:10:14 +0200, Martin Zaťovič wrote:
> GPIO bitbanged Wiegand controller requires definitions of GPIO lines to be
> used on top of the common Wiegand properties. Wiegand utilizes two such
> lines - DATA0(low data line) and DATA1(high data line).
> 
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Martin Zaťovič <m.zatovic1@...il.com>
> ---
>  .../bindings/wiegand/wiegand-gpio.yaml        | 46 +++++++++++++++++++
>  MAINTAINERS                                   |  5 ++
>  2 files changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/wiegand/wiegand-gpio.example.dts:20.21-29.11: Warning (unit_address_vs_reg): /example-0/wiegand@f00: node has a unit name, but no reg or ranges property

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230824111015.57765-4-m.zatovic1@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.