linux-kernel - Re: [PATCH] can: raw: Remove NULL check before dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Aug 2023 09:49:51 +0200
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     mkl@...gutronix.de, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>,
        Simon Horman <horms@...nel.org>
Subject: Re: [PATCH] can: raw: Remove NULL check before dev_{put, hold}

No need to hurry!

This improvement has already been reported by Simon Horman, see this 
discussion:

https://lore.kernel.org/linux-can/20230822200804.GC3523530@kernel.org/

Reported-by: Simon Horman <horms@...nel.org>
Acked-by: Oliver Hartkopp <socketcan@...tkopp.net>

@Marc Kleine-Budde: Can you please take this patch via can-next tree?

Thanks,
Oliver


On 25.08.23 08:46, Jiapeng Chong wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there
> is no need to check before using dev_{put, hold}, remove it to silence
> the warning:
> 
> ./net/can/raw.c:497:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6231
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   net/can/raw.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/can/raw.c b/net/can/raw.c
> index d50c3f3d892f..ff7797c37018 100644
> --- a/net/can/raw.c
> +++ b/net/can/raw.c
> @@ -493,8 +493,7 @@ static int raw_bind(struct socket *sock, struct sockaddr *uaddr, int len)
>   
>   out_put_dev:
>   	/* remove potential reference from dev_get_by_index() */
> -	if (dev)
> -		dev_put(dev);
> +	dev_put(dev);
>   out:
>   	release_sock(sk);
>   	rtnl_unlock();