linux-kernel - Re: [PATCH v2] ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cyzb8stb.wl-tiwai@suse.de>
Date:   Fri, 25 Aug 2023 09:49:52 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Fabian Vogt <fabian@...ter-vogt.de>
Cc:     SungHwan Jung <onenowy@...il.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, perex@...ex.cz
Subject: Re: [PATCH v2] ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx

On Thu, 24 Aug 2023 20:39:48 +0200,
Fabian Vogt wrote:
> 
> The LED for the mic mute button is controlled by GPIO2.
> The mute button LED is slightly more complex, it's controlled by two bits
> in coeff 0x0b.
> 
> Signed-off-by: Fabian Vogt <fabian@...ter-vogt.de>
> ---
> Changes since v1:
> Rebased on 03b0563c2f35. I've got this laptop for almost two years now and
> two days ago decided to dig into the issue with mute LEDs. What amazing timing
> that someone else made the exact same fixup for a different model just hours
> before I submit...
> Renamed quirk to ..._LEDS to distinguish it from the similar quirk which
> handles only one of the mute LEDs.

Applied now.  Thanks.

BTW, at the next time you post a v2 patch, it's better to start a new
thread instead of hanging to the old thread.


Takashi