linux-kernel - Re: [PATCH] mm/khugepaged: increase transparent_hugepage_recommend_disable parameter to disable active modification of min_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Aug 2023 16:38:19 +0800
From:   Liu Song <liusong@...ux.alibaba.com>
To:     corbet@....net, akpm@...ux-foundation.org, paulmck@...nel.org,
        rdunlap@...radead.org, catalin.marinas@....com,
        dave.hansen@...ux.intel.com, rostedt@...dmis.org
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH] mm/khugepaged: increase
 transparent_hugepage_recommend_disable parameter to disable active
 modification of min_free_kbytes

Hi

Any suggestions for this patch? Indeed, too much memory is being 
reserved for the 64K PAGESIZE scenario. Looking forward to everyone's 
suggestions.

Thanks

在 2023/8/17 11:51, Liu Song 写道:
> In the arm64 environment, when PAGESIZE is 4K, the "pageblock_nr_pages"
> value is 512, and the recommended min_free_kbytes in
> "set_recommended_min_free_kbytes" usually does not exceed 44MB.
>
> However, when PAGESIZE is 64K, the "pageblock_nr_pages" value is 8192,
> and the recommended min_free_kbytes in "set_recommended_min_free_kbytes"
> is 8192 * 2 * (2 + 9) * 64K, which directly increases to 11GB.
>
> According to this calculation method, due to the modification of min_free_kbytes,
> the reserved memory in my 128GB memory environment reaches 10GB, and MemAvailable
> is correspondingly reduced by 10GB.
>
> In the case of PAGESIZE 64K, transparent hugepages are 512MB, and we only
> need them to be used on demand. If transparent hugepages cannot be allocated,
> falling back to regular 64K pages is completely acceptable.
>
> Therefore, we added the transparent_hugepage_recommend_disable parameter
> to disable active modification of min_free_kbytes, thereby meeting our
> requirements for transparent hugepages in the 64K scenario, and it will
> not excessively reduce the available memory.
>
> Signed-off-by: Liu Song <liusong@...ux.alibaba.com>
> ---
>   .../admin-guide/kernel-parameters.txt         |  5 +++++
>   mm/khugepaged.c                               | 20 ++++++++++++++++++-
>   2 files changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 654d0d921101..612bdf601cce 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -6553,6 +6553,11 @@
>   			See Documentation/admin-guide/mm/transhuge.rst
>   			for more details.
>   
> +	transparent_hugepage_recommend_disable
> +			[KNL,THP]
> +			Can be used to disable transparent hugepage to actively modify
> +			/proc/sys/vm/min_free_kbytes during enablement process.
> +
>   	trusted.source=	[KEYS]
>   			Format: <string>
>   			This parameter identifies the trust source as a backend
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 78fc1a24a1cc..ac40c618f4f6 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -88,6 +88,9 @@ static unsigned int khugepaged_max_ptes_none __read_mostly;
>   static unsigned int khugepaged_max_ptes_swap __read_mostly;
>   static unsigned int khugepaged_max_ptes_shared __read_mostly;
>   
> +/* default enable recommended */
> +static unsigned int transparent_hugepage_recommend __read_mostly = 1;
> +
>   #define MM_SLOTS_HASH_BITS 10
>   static DEFINE_READ_MOSTLY_HASHTABLE(mm_slots_hash, MM_SLOTS_HASH_BITS);
>   
> @@ -2561,6 +2564,11 @@ static void set_recommended_min_free_kbytes(void)
>   		goto update_wmarks;
>   	}
>   
> +	if (!transparent_hugepage_recommend) {
> +		pr_info("do not allow to recommend modify min_free_kbytes\n");
> +		return;
> +	}
> +
>   	for_each_populated_zone(zone) {
>   		/*
>   		 * We don't need to worry about fragmentation of
> @@ -2591,7 +2599,10 @@ static void set_recommended_min_free_kbytes(void)
>   
>   	if (recommended_min > min_free_kbytes) {
>   		if (user_min_free_kbytes >= 0)
> -			pr_info("raising min_free_kbytes from %d to %lu to help transparent hugepage allocations\n",
> +			pr_info("raising user specified min_free_kbytes from %d to %lu to help transparent hugepage allocations\n",
> +				min_free_kbytes, recommended_min);
> +		else
> +			pr_info("raising default min_free_kbytes from %d to %lu to help transparent hugepage allocations\n",
>   				min_free_kbytes, recommended_min);
>   
>   		min_free_kbytes = recommended_min;
> @@ -2601,6 +2612,13 @@ static void set_recommended_min_free_kbytes(void)
>   	setup_per_zone_wmarks();
>   }
>   
> +static int __init setup_transparent_hugepage_recommend_disable(char *str)
> +{
> +	transparent_hugepage_recommend = 0;
> +	return 1;
> +}
> +__setup("transparent_hugepage_recommend_disable", setup_transparent_hugepage_recommend_disable);
> +
>   int start_stop_khugepaged(void)
>   {
>   	int err = 0;