linux-kernel - Re: [PATCH 7/7] asm-generic/io.h: Expect immutable pointer in virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZQbGEbpTXYm5uOZsAPAzAiSRLRsWZfDMDRFWESBu4cXA@mail.gmail.com>
Date:   Fri, 25 Aug 2023 10:38:20 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>
Cc:     Stanislav Kinsburskii <stanislav.kinsburskii@...il.com>,
        Arnd Bergmann <arnd@...db.de>, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] asm-generic/io.h: Expect immutable pointer in virt_to_phys

On Thu, Apr 27, 2023 at 7:43 PM Stanislav Kinsburskii
<skinsburskii@...ux.microsoft.com> wrote:

> From: Stanislav Kinsburskii <stanislav.kinsburskii@...il.com>
>
> These helper function - virt_to_phys - doesn't need the address pointer to be
> mutable.
>
> In the same time expecting it to be mutable leads to the following build
> warning for constant pointers:
>
>   warning: passing argument 1 of ‘virt_to_phys’ discards ‘const’ qualifier from pointer target type
>
> Signed-off-by: Stanislav Kinsburskii <stanislav.kinsburskii@...il.com>
> CC: Arnd Bergmann <arnd@...db.de>
> CC: linux-arch@...r.kernel.org
> CC: linux-kernel@...r.kernel.org

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I changed several other virt_to_phys() implementations to add const to
the argument and no problems so this should work fine.

Yours,
Linus Walleij