linux-kernel - Re: [PATCH 0/7] Expect immutable pointer in virt_to_phys/isa_virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYCZ0rya3hE+BRrHwP=fASjkpp_Y=BiC=WY-_z0yyRNEg@mail.gmail.com>
Date:   Wed, 3 May 2023 09:32:30 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>
Cc:     Matt Turner <mattst88@...il.com>, x86@...nel.org,
        Stanislav Kinsburskii <stanislav.kinsburskii@...il.com>,
        Borislav Petkov <bp@...en8.de>, linux-ia64@...r.kernel.org,
        Mark Brown <broonie@...nel.org>,
        Richard Henderson <richard.henderson@...aro.org>,
        linux-kernel@...r.kernel.org, Brian Cain <bcain@...cinc.com>,
        linux-mips@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-alpha@...r.kernel.org, linux-arch@...r.kernel.org,
        Michael Ellerman <mpe@...erman.id.au>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Omar Sandoval <osandov@...com>, Helge Deller <deller@....de>,
        linuxppc-dev@...ts.ozlabs.org, linux-hexagon@...r.kernel.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Ingo Molnar <mingo@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        Florian Fainelli <f.fainelli@...il.com>,
        Chris Down <chris@...isdown.name>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 0/7] Expect immutable pointer in virt_to_phys/isa_virt_to_bus
 prototypes

On Thu, Apr 27, 2023 at 7:41 PM Stanislav Kinsburskii
<skinsburskii@...ux.microsoft.com> wrote:

> This series is aimed to address compilation warnings when a constant pointer
> is passed to virt_to_phys and isa_virt_to_bus functions:
>
>   warning: passing argument 1 of ‘virt_to_phys’ discards ‘const’ qualifier from pointer target type
>   warning: passing argument 1 of ‘isa_virt_to_bus’ discards ‘const’ qualifier from pointer target type
>
> The change(s) is the same for all architectures, but it's split into a series on
> per-arch basis to simplify applying and testing on the maintainers side.
>
> The following series implements...

This is nice.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I am working with an adjacent task, which is to make virt_to_pfn() and
pfn_to_virt() into static inlines. I might need to rebase my work on top
of this but it should be doable, I am currently stressing the buildbots
with this with the idea to propose it to Arnd once v6.4-rc1 is out:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator.git/log/?h=b4/virt-to-pfn-v6-4-rc1

Yours,
Linus Walleij