linux-kernel - Re: [PATCH 1/7] x86: asm/io.h: Expect immutable pointer in virt_to_phys/isa_virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZbLX5LCEbGhnRdF9UGsZi81z3sQ-cNABE4wVA+mGb8Qg@mail.gmail.com>
Date:   Fri, 25 Aug 2023 10:39:17 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>
Cc:     Stanislav Kinsburskii <stanislav.kinsburskii@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Arnd Bergmann <arnd@...db.de>,
        Chris Down <chris@...isdown.name>,
        Helge Deller <deller@....de>, Omar Sandoval <osandov@...com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] x86: asm/io.h: Expect immutable pointer in
 virt_to_phys/isa_virt_to_bus prototypes

On Thu, Apr 27, 2023 at 7:42 PM Stanislav Kinsburskii
<skinsburskii@...ux.microsoft.com> wrote:

> From: Stanislav Kinsburskii <stanislav.kinsburskii@...il.com>
>
> These two helper functions - virt_to_phys and isa_virt_to_bus - don't need the
> address pointer to be mutable.
>
> In the same time expecting it to be mutable leads to the following build
> warning for constant pointers:
>
>   warning: passing argument 1 of ‘virt_to_phys’ discards ‘const’ qualifier from pointer target type
>
> Signed-off-by: Stanislav Kinsburskii <stanislav.kinsburskii@...il.com>
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: Ingo Molnar <mingo@...hat.com>
> CC: Borislav Petkov <bp@...en8.de>
> CC: Dave Hansen <dave.hansen@...ux.intel.com>
> CC: x86@...nel.org
> CC: "H. Peter Anvin" <hpa@...or.com>
> CC: Geert Uytterhoeven <geert@...ux-m68k.org>
> CC: Arnd Bergmann <arnd@...db.de>
> CC: Chris Down <chris@...isdown.name>
> CC: Helge Deller <deller@....de>
> CC: Omar Sandoval <osandov@...com>
> CC: linux-kernel@...r.kernel.org

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

This is the right thing to do.

Yours,
Linus Walleij