[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZOh+MBq/GQQUCumT@smile.fi.intel.com>
Date: Fri, 25 Aug 2023 13:10:56 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Linhua Xu <Linhua.xu@...soc.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Orson Zhai <orsonzhai@...il.com>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
Chunyan Zhang <zhang.lyra@...il.com>,
linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
lh xu <xulh0829@...il.com>,
Xiongpeng Wu <xiongpeng.wu@...soc.com>
Subject: Re: [PATCH 2/6] pinctrl: sprd: Fix the incorrect mask and shift
definition
On Fri, Aug 25, 2023 at 11:18:22AM +0800, Linhua Xu wrote:
> From: Linhua Xu <Linhua.Xu@...soc.com>
>
> Pull-up and pull-down are mutually exclusive. When setting one of them,
> the bit of the other needs to be clear. Now, there are cases where pull-up
> and pull-down are set at the same time in the code, thus fix them.
...
> -#define SLEEP_PULL_DOWN_MASK 0x1
> +#define SLEEP_PULL_DOWN_MASK 0x3
GENMASK()
...
> -#define PULL_DOWN_MASK 0x1
> +#define PULL_DOWN_MASK 0x3
GENMASK()
...
> -#define SLEEP_PULL_UP_MASK 0x1
> +#define SLEEP_PULL_UP_MASK 0x3
GENMASK()
...
> -#define PULL_UP_MASK 0x21
> +#define PULL_UP_MASK 0x43
GENMASK() + BIT()?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists