[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZOh+xZqr0RiCLPC3@smile.fi.intel.com>
Date: Fri, 25 Aug 2023 13:13:25 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Linhua Xu <Linhua.xu@...soc.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Orson Zhai <orsonzhai@...il.com>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
Chunyan Zhang <zhang.lyra@...il.com>,
linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
lh xu <xulh0829@...il.com>,
Xiongpeng Wu <xiongpeng.wu@...soc.com>
Subject: Re: [PATCH 3/6] pinctrl: sprd: Modify pull-up parameters
On Fri, Aug 25, 2023 at 11:18:23AM +0800, Linhua Xu wrote:
> From: Linhua Xu <Linhua.Xu@...soc.com>
>
> For UNISOC pin controller, there are three different configurations of
> pull-up drive current: 1 for pull-up resistor is 20K, 2 for pull-up
> resistor is 4.7K and 3 for pull-up resistor is 1.8K. Thus modify them.
...
> - if (arg == 20000)
> - else if (arg == 4700)
> + if (arg == 3)
> + else if (arg == 2)
> + else if (arg == 1)
This will break existing users. What's wrong with leaving this as is
and adding 1.8kOhm?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists