linux-kernel - Re: [PATCH v2 2/2] crypto: qat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOiE6GMY5Qb2S53A@gondor.apana.org.au>
Date:   Fri, 25 Aug 2023 18:39:36 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Lucas Segarra Fernandez <lucas.segarra.fernandez@...el.com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        qat-linux@...el.com, andriy.shevchenko@...el.com, alx@...nel.org,
        Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v2 2/2] crypto: qat - add pm_status debugfs file

On Fri, Aug 18, 2023 at 12:23:09PM +0200, Lucas Segarra Fernandez wrote:
>
> diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c
> index 3bde8759c2a2..911aca862798 100644
> --- a/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c
> +++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c
> @@ -1,8 +1,15 @@
>  // SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0-only)
>  /* Copyright(c) 2022 Intel Corporation */
>  #include <linux/bitfield.h>
> +#include <linux/bits.h>

This is redundant if you include linux/kernel.

> +#include <linux/dma-mapping.h>
> +#include <linux/fs.h>
>  #include <linux/iopoll.h>
>  #include <linux/kstrtox.h>
> +#include <linux/slab.h>
> +#include <linux/stddef.h>

So is this.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt