[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <df519068-c9f0-1051-afb3-75f71ad31791@linaro.org>
Date: Fri, 25 Aug 2023 12:39:47 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Nitheesh Sekar <quic_nsekar@...cinc.com>, agross@...nel.org,
andersson@...nel.org, konrad.dybcio@...aro.org, vkoul@...nel.org,
kishon@...nel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
gregkh@...uxfoundation.org, quic_srichara@...cinc.com,
quic_varada@...cinc.com, quic_wcheng@...cinc.com,
linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-usb@...r.kernel.org
Cc: Amandeep Singh <quic_amansing@...cinc.com>
Subject: Re: [PATCH 4/5] arm64: dts: qcom: ipq5018: Add USB related nodes
On 25/08/2023 11:35, Nitheesh Sekar wrote:
> Add USB phy and controller nodes.
>
> Co-developed-by: Amandeep Singh <quic_amansing@...cinc.com>
> Signed-off-by: Amandeep Singh <quic_amansing@...cinc.com>
> Signed-off-by: Nitheesh Sekar <quic_nsekar@...cinc.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5018.dtsi | 54 +++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> index 9f13d2dcdfd5..ff477923a823 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> @@ -238,6 +238,60 @@
> status = "disabled";
> };
> };
> +
> + usbphy0: phy@...00 {
> + compatible = "qcom,ipq5018-usb-hsphy";
> + reg = <0x0005b000 0x120>;
> +
> + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>;
> +
> + resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
> +
> + #phy-cells = <0>;
> +
> + status = "disabled";
> + };
> +
> + usb: usb2@...0000 {
Eee, where did you put these? Don't stuff things to the end of any list.
This applies to your entire code: Makefile, Kconfig, .c, .h, .dts, .dtsi
and other languages and projects as well.
Krzysztof
Powered by blists - more mailing lists