[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZOiUOcMOeYvMzq58@bergen.fjasle.eu>
Date: Fri, 25 Aug 2023 13:44:57 +0200
From: Nicolas Schier <nicolas@...sle.eu>
To: Masahiro Yamada <masahiroy@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Kees Cook <keescook@...omium.org>,
Bjorn Andersson <andersson@...nel.org>, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, Will Deacon <will@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
quic_pkondeti@...cinc.com, u.kleine-koenig@...gutronix.de,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-msm@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 1/1] scripts: Add add-maintainer.py
On Thu 24 Aug 2023 14:44:36 GMT, Guru Das Srinagesh wrote:
[...]
> > > The script is quiet by default (only prints errors) and its verbosity
> > > can be adjusted via an optional parameter.
> >
> > IMO, it would be nice to see which addresses are effectively added, e.g.
> > comparable to the output of git send-email. Perhaps somehing like:
> >
> > $ scripts/add-maintainer.py *.patch
> > 0001-fixup-scripts-Add-add-maintainer.py.patch: Adding 'To: Guru Das Srinagesh <quic_gurus@...cinc.com>' (maintainer)
> > 0001-fixup-scripts-Add-add-maintainer.py.patch: Adding 'Cc: linux-kernel@...r.kernel.org' (list)
> >
> > Perhaps verbosity should then be configurable.
>
> Yes, this is already implemented - you just need to pass "--verbosity debug" to
> the script. Example based on commit 8648aeb5d7b7 ("power: supply: add Qualcomm
> PMI8998 SMB2 Charger driver") converted to a patch:
>
> $ ./scripts/add-maintainer.py --verbosity debug $u/upstream/patches/test2/0001-power-supply-add-Qualcomm-PMI8998-SMB2-Charger-drive.patch
> INFO: GET: Patch: 0001-power-supply-add-Qualcomm-PMI8998-SMB2-Charger-drive.patch
> DEBUG:
> Sebastian Reichel <sre@...nel.org> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
> Andy Gross <agross@...nel.org> (maintainer:ARM/QUALCOMM SUPPORT)
> Bjorn Andersson <andersson@...nel.org> (maintainer:ARM/QUALCOMM SUPPORT)
> Konrad Dybcio <konrad.dybcio@...aro.org> (maintainer:ARM/QUALCOMM SUPPORT)
> Nathan Chancellor <nathan@...nel.org> (supporter:CLANG/LLVM BUILD SUPPORT)
> Nick Desaulniers <ndesaulniers@...gle.com> (supporter:CLANG/LLVM BUILD SUPPORT)
> Tom Rix <trix@...hat.com> (reviewer:CLANG/LLVM BUILD SUPPORT)
> linux-kernel@...r.kernel.org (open list)
> linux-pm@...r.kernel.org (open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
> linux-arm-msm@...r.kernel.org (open list:ARM/QUALCOMM SUPPORT)
> llvm@...ts.linux.dev (open list:CLANG/LLVM BUILD SUPPORT)
>
> INFO: ADD: Patch: 0001-power-supply-add-Qualcomm-PMI8998-SMB2-Charger-drive.patch
> DEBUG: Cc Lists:
> Cc: linux-arm-msm@...r.kernel.org
> Cc: llvm@...ts.linux.dev
> Cc: linux-pm@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> DEBUG: Cc Others:
> Cc: Tom Rix <trix@...hat.com>
> Cc: Nick Desaulniers <ndesaulniers@...gle.com>
> Cc: Nathan Chancellor <nathan@...nel.org>
> DEBUG: Cc Maintainers:
> None
> DEBUG: To Maintainers:
> To: Sebastian Reichel <sre@...nel.org>
> To: Andy Gross <agross@...nel.org>
> To: Bjorn Andersson <andersson@...nel.org>
> To: Konrad Dybcio <konrad.dybcio@...aro.org>
>
> INFO: Maintainers added to all patch files successfully
>
> The first "GET:" output prints the output of `get_maintainer.pl` verbatim, and
> the "ADD:" output shows what exactly is getting added to that patch. Hope this
> is what you were expecting. Please let me know if you'd prefer any other
> modifications to this debug output.
ups. I tested with --verbosity=info but not with =debug, therefore I
missed it. Sorry for the noise.
[...]
> > While testing, I thought that adding addresses without filtering-out duplicates
> > was odd; but as git-send-email does the unique filtering, it doesn't matter.
>
> Since I'm using `set()` in this script, the uniqueness is guaranteed here as
> well - there won't be any duplicates.
I thought about patch files that already have 'To/Cc' headers (e.g.
'git format-patch --to=... --cc=...' or by running add-maintainer.py
multiple times for updating the lists of recipients. The result is a
patch file with possible duplicated lines; but as written: it does
matter, effectively.
Kind regards,
Nicolas
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists