linux-kernel - Re: [PATCH -next v2] rv/include: set variable 'da_mon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f2be47c-7c35-ec64-7eba-41fdc49af8ca@kernel.org>
Date:   Fri, 25 Aug 2023 15:25:09 +0200
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     Yu Liao <liaoyu15@...wei.com>, rostedt@...dmis.org
Cc:     linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        liwei391@...wei.com
Subject: Re: [PATCH -next v2] rv/include: set variable 'da_mon_##name' to
 static

On 8/23/23 04:00, Yu Liao wrote:
> gcc with W=1 reports
> kernel/trace/rv/monitors/wip/wip.c:20:1: sparse: sparse: symbol 'da_mon_wip' was not declared. Should it be static?
> 
> The per-cpu variable 'da_mon_##name' is only used in its defining file, so
> it should be static.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307280030.7EjUG9gR-lkp@intel.com/
> Signed-off-by: Yu Liao <liaoyu15@...wei.com>

Acked-by: Daniel Bristot de Oliveira <bristot@...nel.org>

Thanks!
-- Daniel