[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d3c634d0-1e0f-4a74-9e5c-1090d5914ba1@roeck-us.net>
Date: Fri, 25 Aug 2023 06:21:34 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: linux-pci@...r.kernel.org, Bjorn Helgaas <helgaas@...nel.org>,
Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/14] hwmon: (sis5595) Do PCI error checks on own line
On Thu, Aug 24, 2023 at 04:28:31PM +0300, Ilpo Järvinen wrote:
> Instead of if conditions with line splits, use the usual error handling
> pattern with a separate variable to improve readability. Handle error
> print with a label instead of trying to chain everything into a single
> if condtion.
s/condtion/condition/
Applied, after fixing that up.
Thanks,
Guenter
Powered by blists - more mailing lists