[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230825135041.GB29260@redhat.com>
Date: Fri, 25 Aug 2023 15:50:42 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: "Eric W. Biederman" <ebiederm@...ssion.com>
Cc: Yonghong Song <yhs@...com>, Kui-Feng Lee <kuifeng@...com>,
Andrii Nakryiko <andrii@...nel.org>,
Martin KaFai Lau <martin.lau@...nel.org>,
bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bpf: task_group_seq_get_next: cleanup the usage of
next_thread()
On 08/25, Eric W. Biederman wrote:
>
> For the record I find this code confusing, and wrong.
Oh, yes...
> and has
> a built in race condition which means it could wind up iterating through
> a different process.
Yes, common->pid and/or common->pid_visiting can be reused
but I am not going to try to fix this ;)
> Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>
Thanks!
Oleg.
Powered by blists - more mailing lists