[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0510a774-07b9-e902-ccac-2fcd44a358dc@linaro.org>
Date: Sat, 26 Aug 2023 13:14:53 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, rfoss@...nel.org,
todor.too@...il.com, agross@...nel.org, andersson@...nel.org,
mchehab@...nel.org, hverkuil-cisco@...all.nl,
laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com,
andrey.konovalov@...aro.org
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 11/15] media: qcom: camss: Functionally decompose
CSIPHY clock lookups
On 26/08/2023 13:11, Konrad Dybcio wrote:
>>> adding something like csiphy_timer_clks and cisphy_clks and stuff
>>> would make this string comparison mess unnecessary
>> I don't understand your comment.
>>
>> Having a litany of static comparisons is definitely inferior to a generic helper function.
> portray this
>
> struct camss_whatever_it_was_called {
> struct clk_bulk_data *csiphy_clks;
> struct clk_bulk_data *csiphy_timer_clks;
> [...]
> }
>
> and then
>
> clk_bulk_prepare_enable(csiphy_clks)
Ah would be grateful if you had just said "hey could you try using
clk_bulk_prepare_enable()"
But, OK.
Thanks !
---
bod
Powered by blists - more mailing lists