linux-kernel - Re: [RFC][PATCH] kconfig: introduce listunknownconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230826055321.GF3913@google.com>
Date:   Sat, 26 Aug 2023 14:53:21 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Ying Sun <sunying@...iscas.ac.cn>,
        Jesse T <mr.bossman075@...il.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        Jonathan Corbet <corbet@....net>,
        Tomasz Figa <tfiga@...omium.org>, linux-kbuild@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] kconfig: introduce listunknownconfig

On (23/08/26 14:38), Masahiro Yamada wrote:
> > I am fine with implementing both.
> >
> > But, I'd like to implement them as separate options.
> > (one option for warn unknown symbols,
> > another for for turning warnings into errors)
> >
> >
> >
> > As I replied to Tomasz, I am considering about
> > env variables vs command line options associated with W= option.
> 
> 
> 
> With a little more thought, the command line option approach
> would require more code changes and efforts.
> 

Sounds good.

> So, I am OK with adding new env variables.
> Could you add two env variables?

Absolutely.

> I think
> 
> the first two hunks (show warnings for symbols not found in Kconfig)
>         -> KCONFIG_WARN_UNKNOWN_SYMBOLS
> 
> the last hunk (turn warnings into errors)
>         -> KCONFIG_WERROR
> 
> (You can suggest a better naming if you have, but I guess
> KCONFIG_WARN_*  will be consistent in case
> more warning requests come up.)

Looks good.

I'll send a patch in the coming days.