linux-kernel - Re: [PATCH] dt-bindings: PCI: qcom: fix SDX65 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230827-eggshell-rift-94f423e74dab@spud>
Date:   Sun, 27 Aug 2023 13:10:28 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Manivannan Sadhasivam <mani@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Rohit Agarwal <quic_rohiagar@...cinc.com>,
        linux-pci@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: qcom: fix SDX65 compatible

On Sun, Aug 27, 2023 at 10:53:51AM +0200, Krzysztof Kozlowski wrote:
> Commit c0aba9f32801 ("dt-bindings: PCI: qcom: Add SDX65 SoC") adding
> SDX65 was not ever tested and is clearly bogus.  The qcom,sdx65-pcie-ep
> compatible is followed by fallback in DTS and there is no driver
> matching by this compatible.  Driver matches by its fallback
> qcom,sdx55-pcie-ep.  This fixes also dtbs_check warnings like:
> 
>   qcom-sdx65-mtp.dtb: pcie-ep@...0000: compatible: ['qcom,sdx65-pcie-ep', 'qcom,sdx55-pcie-ep'] is too long
> 
> Fixes: c0aba9f32801 ("dt-bindings: PCI: qcom: Add SDX65 SoC")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

> ---
>  .../devicetree/bindings/pci/qcom,pcie-ep.yaml        | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> index 811112255d7d..c94b49498f69 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> @@ -11,10 +11,13 @@ maintainers:
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,sdx55-pcie-ep
> -      - qcom,sdx65-pcie-ep
> -      - qcom,sm8450-pcie-ep
> +    oneOf:
> +      - enum:
> +          - qcom,sdx55-pcie-ep
> +          - qcom,sm8450-pcie-ep
> +      - items:
> +          - const: qcom,sdx65-pcie-ep
> +          - const: qcom,sdx55-pcie-ep
>  
>    reg:
>      items:
> @@ -110,7 +113,6 @@ allOf:
>            contains:
>              enum:
>                - qcom,sdx55-pcie-ep
> -              - qcom,sdx65-pcie-ep
>      then:
>        properties:
>          clocks:
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)