[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230827-cackle-unseated-089a2d61ad4b@spud>
Date: Sun, 27 Aug 2023 13:19:26 +0100
From: Conor Dooley <conor@...nel.org>
To: Adam Ford <aford173@...il.com>
Cc: linux-arm-kernel@...ts.infradead.org, aford@...conembedded.com,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Shengjiu Wang <shengjiu.wang@....com>,
alsa-devel@...a-project.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/3] ASoC: dt-bindings: fsl_easrc: Add support for
imx8mp-easrc
On Sat, Aug 26, 2023 at 09:31:53PM -0500, Adam Ford wrote:
> The i.MX8MP appears to have the same easrc support as the Nano, so
> add imx8mp as an option with a fallback to imx8mn.
>
> Signed-off-by: Adam Ford <aford173@...il.com>
> ---
> V2: Fixed errors:
> ['fsl,imx8mn-easrc'] is too short
> 'fsl,imx8mn-easrc' is not one of ['fsl,imx8mp-easrc']
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> index bdde68a1059c..a680d7aff237 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> @@ -14,7 +14,13 @@ properties:
> pattern: "^easrc@.*"
>
> compatible:
> - const: fsl,imx8mn-easrc
> + oneOf:
> + - enum:
> + - fsl,imx8mn-easrc
This one should probably stay const, no?
Either way,
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Thanks,
Conor.
> + - items:
> + - enum:
> + - fsl,imx8mp-easrc
> + - const: fsl,imx8mn-easrc
>
> reg:
> maxItems: 1
> --
> 2.39.2
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists