linux-kernel - Re: [EXT] Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bd01950-20e0-51f1-91d2-88c9ee2e8dc0@linaro.org>
Date:   Mon, 28 Aug 2023 21:30:45 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Shenwei Wang <shenwei.wang@....com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [EXT] Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml
 file

On 28/08/2023 21:23, Shenwei Wang wrote:
>>>>>     reg1: regulator-1 {
>>>>>       compatible = "regulator-fixed";
>>>>>       regulator-name = "REG1";
>>>>>       regulator-min-microvolt = <3000000>;
>>>>>       regulator-max-microvolt = <3000000>;
>>>>>       gpio = <&lsio_gpio4 19 GPIO_ACTIVE_HIGH>;
>>>>>       enable-active-high;
>>>>>     };
>>>>
>>>> There is a chip. This is the chip. If you have there only GPIO pin,
>>>> then your DTS is just wrong. Drop it. If you learn from wrong DTS,
>>>> then sure, power-domain- regulator seems like great idea...
>>>>
>>>
>>> When you talk about the chip, can you please be more specific?
>>
>> What to say more? The device node you quoted above is the regulator. You
>> brought specific example and now claim this is not a regulator, but just GPIO.
>> Please fix your DTS.
>>
> 
> The fixed-regulator is a virtual regulator driver that uses the GPIO pin. 

We do not talk about drivers but bindings and DTS. Why do you bring
again drivers, all the time?

> You claimed this
> as a hardware chip.

??? Sorry, this is getting boring. The DTS-snippet is a hardware chip.
If it is not, then drop it from your DTS. I insist. Srsly, third time I
insist.


> 
> The regulator-pd driver also uses the same GPIO pin. 

Again, what is with the drivers? Can you stop bringing it to the discussion?

> You now claimed this as a software layer.

???

> 
> What's your standard?

I don't think there is anything more to say. You clearly do not
understand what is DTS, schematics and how the actual hardware looks like.

I am not going to respond more to this patchset (which is a clear NAK
just in case).

Best regards,
Krzysztof