linux-kernel - Re: [PATCH 4/7] ASoC: cs35l45: Analog PCM Volume and Amplifier Mode controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOz35ABAsLYROJ4c@finisterre.sirena.org.uk>
Date:   Mon, 28 Aug 2023 20:39:16 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Vlad Karpovich <vkarpovi@...nsource.cirrus.com>
Cc:     James Schulman <james.schulman@...rus.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Rob Herring <robh+dt@...nel.org>, alsa-devel@...a-project.org,
        patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org,
        RicardoRivera-Matosricardo.rivera-matos@...rus.com
Subject: Re: [PATCH 4/7] ASoC: cs35l45: Analog PCM Volume and Amplifier Mode
 controls

On Mon, Aug 28, 2023 at 12:05:22PM -0500, Vlad Karpovich wrote:

> +static int cs35l45_amplifier_mode_put(struct snd_kcontrol *kcontrol,
> +				      struct snd_ctl_elem_value *ucontrol)
> +{

> +	snd_soc_component_enable_pin_unlocked(component, "SPK");
> +	snd_soc_dapm_sync_unlocked(dapm);
> +	snd_soc_dapm_mutex_unlock(dapm);

> +	cs35l45->amplifier_mode = ucontrol->value.integer.value[0];

> +	return 0;
> +}

This should return 1 on change (I did see that there's some code which
generates notifications but it would still be better to flag changes
here, it makes review a lot easier).

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)