linux-kernel - Re: [PATCH] idt77252: remove check of idt77252_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230828124049.6bec893f@kernel.org>
Date:   Mon, 28 Aug 2023 12:40:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Alexandra Diupina <adiupina@...ralinux.ru>
Cc:     Chas Williams <3chas3@...il.com>,
        linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] idt77252: remove check of idt77252_init_ubr() return
 value

On Mon, 28 Aug 2023 17:36:46 +0300 Alexandra Diupina wrote:
> idt77252_init_ubr() always returns 0, so it is possible
> to remove check of its return value
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 2dde18cd1d8f ("Linux 6.5")

How is this a fix and if it was how could the release tag possibly have
caused the issue?

I think this is pointless churn, unless the error handling is buggy
in itself you should leave this code be.
-- 
pw-bot: reject