linux-kernel - RE: [EXT] Re: [PATCH v4 1/1] wifi: mwifiex: added code to support host mlme.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PA4PR04MB9638E9E042C248502DAE810DD1E0A@PA4PR04MB9638.eurprd04.prod.outlook.com>
Date:   Mon, 28 Aug 2023 23:56:01 +0000
From:   David Lin <yu-hao.lin@....com>
To:     Francesco Dolcini <francesco@...cini.it>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sharvari Harisangam <sharvari.harisangam@....com>,
        Pete Hsieh <tsung-hsien.hsieh@....com>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "amitkarwar@...il.com" <amitkarwar@...il.com>,
        "ganapathi017@...il.com" <ganapathi017@...il.com>,
        "huxinming820@...il.com" <huxinming820@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Subject: RE: [EXT] Re: [PATCH v4 1/1] wifi: mwifiex: added code to support
 host mlme.

> From: Francesco Dolcini <francesco@...cini.it>
> Sent: Monday, August 28, 2023 6:10 PM
> To: David Lin <yu-hao.lin@....com>
> Cc: Francesco Dolcini <francesco@...cini.it>; linux-wireless@...r.kernel.org;
> linux-kernel@...r.kernel.org; Sharvari Harisangam
> <sharvari.harisangam@....com>; Pete Hsieh <tsung-hsien.hsieh@....com>;
> kvalo@...nel.org; amitkarwar@...il.com; ganapathi017@...il.com;
> huxinming820@...il.com; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com
> Subject: Re: [EXT] Re: [PATCH v4 1/1] wifi: mwifiex: added code to support
> host mlme.
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> Hello David,
> 
> On Mon, Aug 28, 2023 at 09:30:08AM +0000, David Lin wrote:
> > > On Tue, Aug 15, 2023 at 07:09:25AM +0000, David Lin wrote:
> > > > 1. For station mode first.
> > > > 2. This feature is a must for WPA3.
> > > > 3. Firmware key api version 2 is needed for this feature.
> > > > 4. The code is only enabled and tested with IW416.
> > > > 5. This feature is disabled for other chips.
> > > >
> > > > Signed-off-by: David Lin <yu-hao.lin@....com>
> > >
> > > I think you are missing a few of the comments you received so far.
> > >
> > >  - verify the recipient list, the list here was likely generated with an
> > >    old kernel tree using an outdated MAINTAINERS file
> >
> > I followed your suggestion and issued the command on latest wireless test
> repository.
> 
> Weird, you should have Brian Norris as recipient.
> 

Maybe I will issue the command again for next patch.

> > >  - you need to provide a changelog in your patch, otherwise is not
> > >    possible for other to review
> >
> > Yes, one the cover page.
> 
> Whoops. I missed this since I am not cc: on this series and just found it by
> chance. I would have just expected to have the changelog together with the
> patch and not on the cover, given that it's a single patch.
> 
> Sorry for the misunderstanding, I would appreciate if you could keep me in
> CC from now on, thanks.

O.K. No problem. Thanks for your help.
> 
> Francesco