linux-kernel - Re: [GIT PULL] pstore updates for v6.6-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Aug 2023 16:56:00 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
        Enlin Mu <enlin.mu@...soc.com>,
        Eric Biggers <ebiggers@...gle.com>,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Yunlong Xing <yunlong.xing@...soc.com>,
        Yuxiao Zhang <yuxiaozhang@...gle.com>
Subject: Re: [GIT PULL] pstore updates for v6.6-rc1

On Mon, 28 Aug 2023 at 11:21, Kees Cook <keescook@...omium.org> wrote:
>
> Please pull these pstore updates for v6.6-rc1. This contains a fair bit
> of code _removal_ which is always nice.

Hmm. The diffstat certainly looks good, but the end result isn't great..

I now get 124 lines of

   pstore: zlib_inflate() failed, ret = -5!

in my bootup dmesg.

Considering that there's no reason for pstore to even be active on
this machine, I think it's because pstore now goes and tries to
uncompress something entirely invalid.

The message itself does not seem to be new, but with the switch from
the crypto code, it apparently used to be

    crypto_comp_decompress failed, ret = %d!

but the key word here is *apparently*. I never got that message
before. So something else has changed, and I'm thinking that the old
code probably didn't even try to decompress the bogus data it found?

I dunno. But 124 lines of insane garbage in the kernel messages is not
a good thing.

                  Linus