linux-kernel - Re: [EXT] Re: [PATCH v5 01/11] dt-bindings: arm: fsl: add imx-se-fw binding doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f983d06-e82b-e572-e007-18d39c15ead7@linaro.org>
Date:   Mon, 28 Aug 2023 08:55:05 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Varun Sethi <V.Sethi@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Rob Herring <robh@...nel.org>, Pankaj Gupta <pankaj.gupta@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "clin@...e.com" <clin@...e.com>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "pierre.gondois@....com" <pierre.gondois@....com>,
        Jacky Bai <ping.bai@....com>,
        Clark Wang <xiaoning.wang@....com>,
        Wei Fang <wei.fang@....com>, Peng Fan <peng.fan@....com>,
        Bough Chen <haibo.chen@....com>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gaurav Jain <gaurav.jain@....com>,
        "alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>,
        Sahil Malhotra <sahil.malhotra@....com>,
        Aisheng Dong <aisheng.dong@....com>
Subject: Re: [EXT] Re: [PATCH v5 01/11] dt-bindings: arm: fsl: add imx-se-fw
 binding doc

On 28/08/2023 08:00, Varun Sethi wrote:
> Hi Greg,
> 
>> -----Original Message-----
>> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Sent: Friday, August 25, 2023 12:54 AM
>> To: Krzysztof Kozlowski <krzk@...nel.org>
>> Cc: Rob Herring <robh@...nel.org>; Pankaj Gupta
>> <pankaj.gupta@....com>; shawnguo@...nel.org; s.hauer@...gutronix.de;
>> kernel@...gutronix.de; clin@...e.com; conor+dt@...nel.org;
>> pierre.gondois@....com; Jacky Bai <ping.bai@....com>; Clark Wang
>> <xiaoning.wang@....com>; Wei Fang <wei.fang@....com>; Peng Fan
>> <peng.fan@....com>; Bough Chen <haibo.chen@....com>;
>> festevam@...il.com; dl-linux-imx <linux-imx@....com>;
>> davem@...emloft.net; krzysztof.kozlowski+dt@...aro.org; linux-arm-
>> kernel@...ts.infradead.org; devicetree@...r.kernel.org; linux-
>> kernel@...r.kernel.org; Gaurav Jain <gaurav.jain@....com>;
>> alexander.stein@...tq-group.com; Sahil Malhotra
>> <sahil.malhotra@....com>; Aisheng Dong <aisheng.dong@....com>; Varun
>> Sethi <V.Sethi@....com>
>> Subject: [EXT] Re: [PATCH v5 01/11] dt-bindings: arm: fsl: add imx-se-fw
>> binding doc
>>
>> Caution: This is an external email. Please take care when clicking links
> or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On Thu, Aug 24, 2023 at 08:45:41PM +0200, Krzysztof Kozlowski wrote:
>>> On 23/08/2023 14:43, Rob Herring wrote:
>>>>> +                                                          |
>>>>> +  +------------------------------------------------------ |
>>>>> +                     |             |           |          |
>>>>> +  userspace     /dev/ele_muXch0    |           |          |
>>>>> +                           /dev/ele_muXch1     |          |
>>>>> +                                         /dev/ele_muXchY  |
>>>>> +                                                          |
>>>>> +
>>>>> +  When a user sends a command to the firmware, it registers its
>>>>> + device_ctx  as waiter of a response from firmware.
>>>>> +
>>>>> +  A user can be registered as receiver of command from the ELE.
>>>>> +  Create char devices in /dev as channels of the form
>>>>> + /dev/ele_muXchY with X  the id of the driver and Y for each
>>>>> + users. It allows to send and receive  messages to the NXP
>>>>> + EdgeLock Enclave IP firmware on NXP SoC, where current  possible
>> value, i.e., supported SoC(s) are imx8ulp, imx93.
>>>>
>>>> Looks like a bunch of Linux details which don't belong in the binding.
>>>>
>>>> Why do you need your own custom interface to userspace? No one else
>>>> has a similar feature in their platforms? Something like virtio or
>>>> rpmsg doesn't work?
>>>
>>> +Cc Greg,
>>>
>>> I doubt they care. This is some stub-driver to pass messages from
>>> user-space to the firmware. The interface is undocumented, without
>>> examples and no user-space user.
>>
>> Great, no user?  Let's delete the code then :)
>>
> [Varun] We do have middleware applications that utilize the driver.
> Following
> are the links:
> https://github.com/nxp-imx/imx-secure-enclave
> https://github.com/nxp-imx/imx-smw
> 

Why this is not explained in the cover letter and in the patch adding
the interfaces? You still need to document and explain the interface.

Best regards,
Krzysztof