linux-kernel - Re: [PATCH v4 2/2] USB: typec: Add TI TPS25750 USB Type-C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230828101456.3245zuhlqdjjxzqy@pengutronix.de>
Date:   Mon, 28 Aug 2023 12:14:56 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Abdel Alkuor <alkuor@...il.com>
Cc:     heikki.krogerus@...ux.intel.com, devicetree@...r.kernel.org,
        gregkh@...uxfoundation.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        abdelalkuor@...tab.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] USB: typec: Add TI TPS25750 USB Type-C controller

Hello,

On Sun, Aug 20, 2023 at 03:32:27PM -0400, Abdel Alkuor wrote:
> +static struct i2c_driver tps25750_i2c_driver = {
> +	.driver = {
> +		.name = "tps25750",
> +		.pm = pm_ptr(&tps25750_pm_ops),
> +		.of_match_table = tps25750_of_match,
> +	},
> +	.probe_new = tps25750_probe,
> +	.remove = tps25750_remove,
> +	.id_table = tps25750_id,
> +};

Please use .probe instead of .probe_new. Apart from just dropping "_new"
here, nothing is needed. .probe_new will go away soon.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)