linux-kernel - Re: [PATCH v4 0/2] Add support for TPS25750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOWvG1MQw37IOHcM@kuha.fi.intel.com>
Date:   Wed, 23 Aug 2023 10:02:51 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Abdel Alkuor <alkuor@...il.com>
Cc:     devicetree@...r.kernel.org, gregkh@...uxfoundation.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, abdelalkuor@...tab.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v4 0/2] Add support for TPS25750

On Sun, Aug 20, 2023 at 03:32:25PM -0400, Abdel Alkuor wrote:
> TPS25750 is USB Type-C and PD controller. The device is
> highly configurable using App Customization online Tool 
> developed by TI to generate loadable binary.
> 
> TPS25750 supports three modes; PTCH, APP, and BOOT. A configuration
> can only be applied when the controller is on PTCH mode.
> 
> The controller attempts to load a configuration from EEPROM on
> I2Cm bus. If no EEPROM is detected, then the driver tries to load
> a configuration on I2Cs bus using a firmware file defined
> in DT.
> 
> The driver implements the binary loading sequence which 
> can be found on pg.53 in TPS25750 Host Interface Technical
> Reference Manual (Rev. A) https://tinyurl.com/y9rkhu8a
> 
> The driver only supports resume pm callback as power management is
> automatically controlled by the device. See pg.47 in TPS25750
> datasheet https://tinyurl.com/3vfd2k43
> 
> v4:
>  - PATCH 1: No change
>  - PATCH 2: Fix comments style and drop of_match_ptr
> v3:
>  - PATCH 1: Fix node name
>  - PATCH 2: Upload tps25750 driver patch
> v2:
>  - PATCH 1: General properties clean up
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Abdel Alkuor (2):
>   dt-bindings: usb: Add ti,tps25750
>   USB: typec: Add TI TPS25750 USB Type-C controller
> 
>  .../devicetree/bindings/usb/ti,tps25750.yaml  |   81 ++
>  drivers/usb/typec/Kconfig                     |   13 +
>  drivers/usb/typec/Makefile                    |    1 +
>  drivers/usb/typec/tps25750.c                  | 1077 +++++++++++++++++
>  drivers/usb/typec/tps25750.h                  |  162 +++
>  5 files changed, 1334 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/ti,tps25750.yaml
>  create mode 100644 drivers/usb/typec/tps25750.c
>  create mode 100644 drivers/usb/typec/tps25750.h

TPS25750 has the same host interface as TI TPS65xxx controllers, no?
The register offsets at least are exactly the same.

You need to first try to incorporate support for TI25750 support into
the existing tipd driver (drivers/usb/typec/tipd/).

thanks,

-- 
heikki