linux-kernel - Re: [PATCH] char: hw_random: xgene-rng: removed unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230828114806.cjshfg7tpxiwyy6i@viti.kaiser.cx>
Date:   Mon, 28 Aug 2023 13:48:06 +0200
From:   Martin Kaiser <lists@...ser.cx>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        yuzhe@...china.com, u.kleine-koenig@...gutronix.de,
        herbert@...dor.apana.org.au, olivia@...enic.com, alex@...uggie.ro
Subject: Re: [PATCH] char: hw_random: xgene-rng: removed unneeded call to
 platform_set_drvdata()

Andrei Coardos (aboutphysycs@...il.com) wrote:

> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.

> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
>  drivers/char/hw_random/xgene-rng.c | 1 -
>  1 file changed, 1 deletion(-)

> diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c
> index 7c8f3cb7c6af..9d64b5931a27 100644
> --- a/drivers/char/hw_random/xgene-rng.c
> +++ b/drivers/char/hw_random/xgene-rng.c
> @@ -321,7 +321,6 @@ static int xgene_rng_probe(struct platform_device *pdev)
>  		return -ENOMEM;

>  	ctx->dev = &pdev->dev;
> -	platform_set_drvdata(pdev, ctx);

>  	ctx->csr_base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(ctx->csr_base))
> -- 
> 2.34.1

This one's ok, too. 67fb1e295839 ("hwrng: xgene - Simplify using
devm_clk_get_optional_enabled()") removed the platform_get_drvdata call.

Reviewed-by: Martin Kaiser <martin@...ser.cx>