linux-kernel - Re: [PATCH 2/6] selftests/cachestat: Fix print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKEwX=N8dEFEGXdARQG-1_TrCk7=acWbYgc-jRT=R6+O7=VMig@mail.gmail.com>
Date:   Mon, 28 Aug 2023 10:04:00 -0400
From:   Nhat Pham <nphamcs@...il.com>
To:     "Wieczor-Retman, Maciej" <maciej.wieczor-retman@...el.com>
Cc:     Johannes Weiner <hannes@...xchg.org>,
        Shuah Khan <shuah@...nel.org>, ilpo.jarvinen@...ux.intel.com,
        reinette.chatre@...el.com, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] selftests/cachestat: Fix print_cachestat format

On Mon, Aug 28, 2023 at 10:00 AM Nhat Pham <nphamcs@...il.com> wrote:
>
> On Mon, Aug 28, 2023 at 6:50 AM Wieczor-Retman, Maciej
> <maciej.wieczor-retman@...el.com> wrote:
> >
> > The format specifier in printf() call expects long int variables and
> > received long long int.
> >
> > Change format specifiers to long long int so they match passed
> > variables.
> >
> > Signed-off-by: Wieczor-Retman, Maciej <maciej.wieczor-retman@...el.com>
> > ---
> >  tools/testing/selftests/cachestat/test_cachestat.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c
> > index 77620e7ecf56..a7adf42afb20 100644
> > --- a/tools/testing/selftests/cachestat/test_cachestat.c
> > +++ b/tools/testing/selftests/cachestat/test_cachestat.c
> > @@ -25,7 +25,7 @@ static const char * const dev_files[] = {
> >  void print_cachestat(struct cachestat *cs)
> >  {
> >         ksft_print_msg(
> > -       "Using cachestat: Cached: %lu, Dirty: %lu, Writeback: %lu, Evicted: %lu, Recently Evicted: %lu\n",
> > +       "Using cachestat: Cached: %llu, Dirty: %llu, Writeback: %llu, Evicted: %llu, Recently Evicted: %llu\n",
> The fields of struct cachestat should all be unsigned longs,
> Is there a compiler warning that prompt this change?
Ah nvm, it's _u64. %llu is probably the better format specifier indeed.

Acked-by: Nhat Pham <nphamcs@...il.com>
> >         cs->nr_cache, cs->nr_dirty, cs->nr_writeback,
> >         cs->nr_evicted, cs->nr_recently_evicted);
> >  }
> > --
> > 2.42.0
> >