linux-kernel - Re: [PATCH] vfs: use helpers for calling f_op->{read,write}_iter() in read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230828140934.GY3390869@ZenIV>
Date:   Mon, 28 Aug 2023 15:09:34 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Christian Brauner <brauner@...nel.org>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Kemeng Shi <shikemeng@...weicloud.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfs: use helpers for calling f_op->{read,write}_iter()
 in read_write.c

On Mon, Aug 28, 2023 at 02:30:42PM +0200, Christian Brauner wrote:
> On Mon, Aug 28, 2023 at 05:00:36AM -0700, Christoph Hellwig wrote:
> > On Mon, Aug 28, 2023 at 11:50:56PM +0800, Kemeng Shi wrote:
> > > use helpers for calling f_op->{read,write}_iter() in read_write.c
> > > 
> > 
> > Why?  We really should just remove the completely pointless wrappers
> > instead.
> 
> Especially because it means you chase this helper to figure out what's
> actually going on. If there was more to it then it would make sense but
> not just as a pointless wrapper.

It's borderline easier to grep for, but not dramatically so.  call_mmap()
has a stronger argument in favour - there are several methods called
->mmap and telling one from another is hard without looking into context.

For ->{read,write}_iter() I'd prefer to get rid of the wrappers.